[PATCH] mtd: spi-nor: esmt: Add support for F25L16PA

[, R_R]

Hi, Michael.
Thanks for your feedback!

On Sat, Jul 3, 2021 at 12:11 AM Michael Walle <michael at walle.cc> wrote:
>
> Hi,
>
> Am 2021-06-30 19:54, schrieb Jihoon Han:
> > Add support for F25L16PA which is 2MB SPI-NOR Chip manufactured by
> > ESMT.
> >
> > Tested on Qualcomm QCA9557 based DW02-412H router.
> >
> > Datasheet:
> > https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L16PA_1(2S).pdf
>
> Please put it into one line and just before your Signed-off-by so it
> will be tag.
>

I will fix it for v2.

> >
> > Signed-off-by: Jihoon Han <rapid_renard at renard.ga>
> > ---
> >  drivers/mtd/spi-nor/esmt.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/esmt.c b/drivers/mtd/spi-nor/esmt.c
> > index cfc9218c1053..2ebeecd6c957 100644
> > --- a/drivers/mtd/spi-nor/esmt.c
> > +++ b/drivers/mtd/spi-nor/esmt.c
> > @@ -10,6 +10,8 @@
> >
> >  static const struct flash_info esmt_parts[] = {
> >       /* ESMT */
> > +     { "f25l16pa", INFO(0x8c2115, 0, 64 * 1024, 32,
> > +                        SECT_4K | SPI_NOR_HAS_LOCK) },
> >       { "f25l32pa", INFO(0x8c2016, 0, 64 * 1024, 64,
> >                          SECT_4K | SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE) },
> >       { "f25l32qa", INFO(0x8c4116, 0, 64 * 1024, 64,
>
> There is a F25L16PA which has a different ID (0x8c2015). So we have to
> agree
> on a different name.
>
> See also
> https://lore.kernel.org/linux-mtd/20210620085639.143694-1-mans0n@gorani.run/
>
> --
> -michael

According to the datasheet, the previously produced F25L16PA has an ID
of 0x8c2015, and the subsequently produced F25L16PA(2S) has an ID of
0x8c2115.
Since I have only tested F25L16PA(2S), I would like to revise the
model name to "f25l16pa-2s" as the conclusion discussed in that patch
and submit the revised patch.