[PATCH 2/2] mtd: spi-nor: Disable the flash quad mode in spi_nor_restore()

[Matthias Weißer]

Am Fr., 4. Sept. 2020 um 09:55 Uhr schrieb Yicong Yang
<yangyicong at hisilicon.com>:
> > Given the fact that setting and unsetting NV bit causes wearing of this
> > rather important bit and also breaks backward compatibility of tools
> > that expect Kernel to set QE bit on flashing, I suggest reverting these patches:
> >
> > cc59e6bb6cd6 mtd: spi-nor: Disable the flash quad mode in spi_nor_restore()
> > be192209d5a3 mtd: spi-nor: Add capability to disable flash quad mode
>
> I've send the revert patches. You may found at :
> https://lore.kernel.org/linux-mtd/1599205640-26690-1-git-send-email-yangyicong@hisilicon.com/

Thanks. I think this is currently the way to go.

> but I still have something uncertain, I think we should avoid setting the non-volatile bits
> in spi-nor driver, should we?

Why not? If quad mode should be used the QE bit has to be set. There is no
other way to enable quad mode (on the devices I am aware of).

Regards,
Matthias