[PATCH 2/2] mtd: spi-nor: Disable the flash quad mode in spi_nor_restore()

Matthias Weißer m.weisser.m at gmail.com
Wed Sep 2 08:15:19 EDT 2020


Hi Vignesh

Am Di., 1. Sept. 2020 um 16:20 Uhr schrieb Yicong Yang
<yangyicong at hisilicon.com>:
> I've tested the following patch with s25fs128s1.
> I left the flash quad enabled before managed by spi-nor driver,
> and it'll stay QE after removed. So I think it'll also address the issue
> mentioned. Please have a test.

Thanks for the patch. I can confirm that current 5.9-rc3 bricks my hardware
and your patch on top of it fixes that. Therefore

Tested-by: Matthias Weisser <m.weisser.m at gmail.com>

But I am still concerned about wearing out nonvolatile QE bits (not in my
case, but there may be others) which may also brick hardware after a lot of
boots (by set and reset QE bit on every boot).

So, from my limited point of view, your patch fixes my problem but overall
I think the original approach should be thought-out a bit more.

Regards,
Matthias



More information about the linux-mtd mailing list