[PATCH] mtd: nand: Change dependency between the NAND and ECC cores
Miquel Raynal
miquel.raynal at bootlin.com
Thu Nov 19 16:06:48 EST 2020
On Fri, 2020-11-13 at 12:39:45 UTC, Miquel Raynal wrote:
> The NAND ECC core is included in the generic NAND core when it is
> compiled in.
>
> Different software ECC engines drivers will select the NAND ECC core
> and thus also have a dependency on the NAND core. Using a "depends on"
> between the two leads to possible cases (not real cases, but created
> by robots) where one is still unselected because of the "select does
> not verifies depends on" game:
>
> WARNING: unmet direct dependencies detected for MTD_NAND_ECC
> Depends on [n]: MTD [=m] && MTD_NAND_CORE [=n]
> Selected by [m]:
> - MTD_NAND_ECC_SW_HAMMING [=y] && MTD [=m]
> - MTD_NAND_ECC_SW_BCH [=y] && MTD [=m]
>
> Fix this by using a select instead.
>
> Reported-by: Randy Dunlap <rdunlap at infradead.org>
> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> Acked-by: Randy Dunlap <rdunlap at infradead.org> # build-tested
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next.
Miquel
More information about the linux-mtd
mailing list