[PATCH] mtd: nand: Change dependency between the NAND and ECC cores

[Randy Dunlap]

On 11/13/20 4:39 AM, Miquel Raynal wrote:
> The NAND ECC core is included in the generic NAND core when it is
> compiled in.
> 
> Different software ECC engines drivers will select the NAND ECC core
> and thus also have a dependency on the NAND core. Using a "depends on"
> between the two leads to possible cases (not real cases, but created
> by robots) where one is still unselected because of the "select does
> not verifies depends on" game:
> 
> WARNING: unmet direct dependencies detected for MTD_NAND_ECC
>   Depends on [n]: MTD [=m] && MTD_NAND_CORE [=n]
>   Selected by [m]:
>   - MTD_NAND_ECC_SW_HAMMING [=y] && MTD [=m]
>   - MTD_NAND_ECC_SW_BCH [=y] && MTD [=m]
> 
> Fix this by using a select instead.
> 
> Reported-by: Randy Dunlap <rdunlap at infradead.org>
> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>

Acked-by: Randy Dunlap <rdunlap at infradead.org> # build-tested

Thanks.

> ---
>  drivers/mtd/nand/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 15ffe1a1b863..b40455234cbd 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -13,7 +13,7 @@ menu "ECC engine support"
>  
>  config MTD_NAND_ECC
>         bool
> -       depends on MTD_NAND_CORE
> +       select MTD_NAND_CORE
>  
>  config MTD_NAND_ECC_SW_HAMMING
>  	bool "Software Hamming ECC engine"
> 


-- 
~Randy