[Outreachy kernel] Re: [PATCH NAND 0/5] Replace printk statements with pr_*macros

[Boris Brezillon]

On Fri, 16 Feb 2018 14:26:56 -0300
Ezequiel Garcia <ezequiel at vanguardiasur.com.ar> wrote:

> On 16 February 2018 at 14:23, Julia Lawall <julia.lawall at lip6.fr> wrote:
> >
> >
> > On Fri, 16 Feb 2018, Ezequiel Garcia wrote:
> >  
> >> Hi Shreeya,
> >>
> >> Thanks for the contribution.
> >>
> >> On 16 February 2018 at 13:50, Shreeya Patel
> >> <shreeya.patel23498 at gmail.com> wrote:  
> >> > This patchset removes all the log levels i.e. KERN_WARN,
> >> > KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk
> >> > statements and replaces the printk statements with appropriate
> >> > pr_*macros.
> >> > According to the kernel coding style, pr_*macro is the preferred
> >> > way to print the message.
> >> >  
> >>
> >> So, two things to begin with.
> >>
> >> First of all, despite this contribution being part of outreachy,
> >> I believe you can include mailing lists in your case.
> >>
> >> In other words, don't use the "nol" option in get_maintainer
> >> script and Cc the MTD mailing list: linux-mtd at lists.infradead.org.  
> >
> > Shouldn't the dev_* functions also be usable?
> >  
> 
> Provided that:
> 1. it's applicable, i.e. if in the context of a device.

Yep, be careful with that. The MTD/NAND subsystem initializes
mtd->dev.name quite late, so it's not safe to use &mtd->dev with
dev_<loglevel>(). Note that you can use the NAND controller pdev->dev if
available.

> 2. Richard is not too opposed to the idea.
> 
> Then, yes.



-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com