[Outreachy kernel] Re: [PATCH NAND 0/5] Replace printk statements with pr_*macros
ezequiel at vanguardiasur.com.ar
Fri Feb 16 09:26:56 PST 2018
On 16 February 2018 at 14:23, Julia Lawall <julia.lawall at lip6.fr> wrote:
> On Fri, 16 Feb 2018, Ezequiel Garcia wrote:
>> Hi Shreeya,
>> Thanks for the contribution.
>> On 16 February 2018 at 13:50, Shreeya Patel
>> <shreeya.patel23498 at gmail.com> wrote:
>> > This patchset removes all the log levels i.e. KERN_WARN,
>> > KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk
>> > statements and replaces the printk statements with appropriate
>> > pr_*macros.
>> > According to the kernel coding style, pr_*macro is the preferred
>> > way to print the message.
>> So, two things to begin with.
>> First of all, despite this contribution being part of outreachy,
>> I believe you can include mailing lists in your case.
>> In other words, don't use the "nol" option in get_maintainer
>> script and Cc the MTD mailing list: linux-mtd at lists.infradead.org.
> Shouldn't the dev_* functions also be usable?
1. it's applicable, i.e. if in the context of a device.
2. Richard is not too opposed to the idea.
Ezequiel García, VanguardiaSur
More information about the linux-mtd