[PATCH] mtd: nandsim: remove debugfs entries in error path

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Aug 23 02:12:39 PDT 2017


Hello,

On Wed, Aug 23, 2017 at 10:40:52AM +0200, Boris Brezillon wrote:
> On Wed, 23 Aug 2017 09:03:04 +0200
> Uwe Kleine-König <u.kleine-koenig at pengutronix.de> wrote:
> 
> > The debugfs entries must be removed before an error is returned in the
> > probe function. Otherwise another try to load the module fails and when
> > the debugfs files are accessed without the module loaded, the kernel
> > still tries to call a function in that module.
> 
> Unfortunately this patch conflicts with [1], but feel free to send it to
> stable with my
> 
> Acked-by: Boris Brezillon <boris.brezillon at free-electrons.com>
>
> [1]http://git.infradead.org/l2-mtd.git/commit/e8e3edb95ce6a146bc774b6cfad3553f4383edc8

I didn't test, but I think e8e3edb95ce6a146bc774b6c should fix the
issue, too.

The key question now is: Is my fix
(http://patchwork.ozlabs.org/patch/804837/) important enough to still go
into 4.13 (e8e3edb95ce6a146bc774b6c certainly isn't suitable here)? If
yes, it "only" creates a merge conflict that should be trivial to fix.
If it's to late for 4.13 then my patch should go into stable with an
updated comment that references e8e3edb95ce6a146bc774b6c.

What do you think?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-mtd mailing list