[PATCH] mtd: nandsim: remove debugfs entries in error path
Boris Brezillon
boris.brezillon at free-electrons.com
Wed Aug 23 01:40:52 PDT 2017
On Wed, 23 Aug 2017 09:03:04 +0200
Uwe Kleine-König <u.kleine-koenig at pengutronix.de> wrote:
> The debugfs entries must be removed before an error is returned in the
> probe function. Otherwise another try to load the module fails and when
> the debugfs files are accessed without the module loaded, the kernel
> still tries to call a function in that module.
Unfortunately this patch conflicts with [1], but feel free to send it to
stable with my
Acked-by: Boris Brezillon <boris.brezillon at free-electrons.com>
Regards,
Boris
[1]http://git.infradead.org/l2-mtd.git/commit/e8e3edb95ce6a146bc774b6cfad3553f4383edc8
>
> Fixes: 5346c27c5fed ("mtd: nandsim: Introduce debugfs infrastructure")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
> drivers/mtd/nand/nandsim.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> index 03a0d057bf2f..e4211c3cc49b 100644
> --- a/drivers/mtd/nand/nandsim.c
> +++ b/drivers/mtd/nand/nandsim.c
> @@ -2373,6 +2373,7 @@ static int __init ns_init_module(void)
> return 0;
>
> err_exit:
> + nandsim_debugfs_remove(nand);
> free_nandsim(nand);
> nand_release(nsmtd);
> for (i = 0;i < ARRAY_SIZE(nand->partitions); ++i)
More information about the linux-mtd
mailing list