[PATCH] mtd: spi-nor: update flags for n25q128a

Rafał Miłecki zajec5 at gmail.com
Sat Feb 27 03:25:21 PST 2016


On 27 February 2016 at 03:07, Ezequiel Garcia
<ezequiel at vanguardiasur.com.ar> wrote:
> @@ -864,8 +864,12 @@ static const struct flash_info spi_nor_ids[] = {
>         { "n25q032a",    INFO(0x20bb16, 0, 64 * 1024,   64, SPI_NOR_QUAD_READ) },
>         { "n25q064",     INFO(0x20ba17, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_QUAD_READ) },
>         { "n25q064a",    INFO(0x20bb17, 0, 64 * 1024,  128, SECT_4K | SPI_NOR_QUAD_READ) },
> -       { "n25q128a11",  INFO(0x20bb18, 0, 64 * 1024,  256, SPI_NOR_QUAD_READ) },
> -       { "n25q128a13",  INFO(0x20ba18, 0, 64 * 1024,  256, SPI_NOR_QUAD_READ) },
> +       { "n25q128a11",  INFO(0x20bb18, 0, 64 * 1024,  256,
> +                SECT_4K | SPI_NOR_QUAD_READ |
> +                SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "n25q128a13",  INFO(0x20ba18, 0, 64 * 1024,  256,
> +                SECT_4K | SPI_NOR_QUAD_READ |
> +                SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },

We use one line per chip, so please keep stick to this formatting. I
can guess you wanted to follow kernel's coding style, but this adds
inconsistency. Also kernel's coding style allows lines over 80 chars
for better readibility. If we are ever going to change it, it should
be a separated patch affecting all entries.

-- 
Rafał



More information about the linux-mtd mailing list