[PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers

Scott Wood oss at buserror.net
Mon Feb 1 14:26:51 PST 2016


On Mon, 2016-02-01 at 16:16 +0530, Raghav Dogra wrote:
>  /*
>   * IFC Controller Registers
>   */
> -struct fsl_ifc_regs {
> +struct fsl_ifc_fcm {
>  	__be32 ifc_rev;
>  	u32 res1[0x2];
>  	struct {

This struct is not specific to fcm (i.e. nand).  Please choose a better name,
such as fsl_ifc_global (which would match "gregs").

-Scott




More information about the linux-mtd mailing list