[PATCH v2] mtd: nand: pxa3xx_nand: add register access debug

Brian Norris computersforpeace at gmail.com
Mon Feb 1 10:00:03 PST 2016


On Fri, Jan 29, 2016 at 11:47:07AM -0300, Ezequiel Garcia wrote:
> On 25 Jan 09:29 PM, Robert Jarzmik wrote:
> > Add verbose debug for register accesses. This enables easier debugging
> > by following where and how hardware is stimulated, and how it answers.
> > 
> > Signed-off-by: Robert Jarzmik <robert.jarzmik at free.fr>
> > ---
[...]
> 
> With verbose debug enabled, it looks like this:
> 
> [..]
> [   99.909883] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():793 nand_readl(0x0014): 0x1
> [   99.909896] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():843 nand_writel(0x1, 0x0014)
> [   99.909902] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():857 nand_writel(0x300d3000, 0x0048)
> [   99.909909] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():858 nand_writel(0x60000, 0x0048)
> [   99.909915] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():859 nand_writel(0x0, 0x0048)
> [   99.909921] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():863 nand_writel(0x820, 0x0048)
> [   99.910037] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():793 nand_readl(0x0014): 0x2
> 
> Maybe it would look clearer with:
> 
> [   99.910037] pxa3xx-nand f10d0000.nand: pxa3xx_nand_irq():793 nand_readl(0x0014) = 0x2

Seems reasonable. I made that change myself, and applied it to
l2-mtd.git.

> But if you feel it's just bikeshedding then:

Maybe :)

> Acked-by: Ezequiel Garcia <ezequiel at vanguardiasur.com.ar>

Thanks!



More information about the linux-mtd mailing list