[PATCH 1/2 v2] nand_base: SOFT_BCH: Request strength over bytes

Aaron Sierra asierra at xes-inc.com
Thu Jan 29 08:46:08 PST 2015


----- Original Message -----
> From: "Aaron Sierra" <asierra at xes-inc.com>
> Sent: Wednesday, January 14, 2015 5:41:31 PM
> 
> Previously, we requested that drivers pass ecc.size and ecc.bytes when
> using NAND_ECC_SOFT_BCH. However, a driver is likely to only know the ECC
> strength required for its NAND, so each driver would need to perform a
> strength-to-bytes calculation.
> 
> Avoid duplicating this calculation in each driver by asking drivers to
> pass ecc.size and ecc.strength so that the strength-to-bytes calculation
> need only be implemented once.
> 
> This reverts/generalizes this commit:
>     mtd: nand: Base BCH ECC bytes on required strength
> 
> Signed-off-by: Aaron Sierra <asierra at xes-inc.com>
> Reviewed-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> ---
> v2:
>     * nandsim: Set ECC strength to chip->ecc.strength
>     * nand_base: Don't provide ECC bytes-to-strength backward compat
> 
>  drivers/mtd/nand/nand_base.c  | 14 ++++++++------
>  drivers/mtd/nand/nandsim.c    |  1 +
>  drivers/mtd/nand/sunxi_nand.c |  2 --
>  3 files changed, 9 insertions(+), 8 deletions(-)
> 

Is this patch still being considered despite the changes requested for
the 2nd patch in this series?

-Aaron



More information about the linux-mtd mailing list