[PATCH v2] mtd: nftl: reorganize operations in condition check

Andy Shevchenko andy.shevchenko at gmail.com
Sat Jan 10 04:56:32 PST 2015


On Sat, Jan 10, 2015 at 1:29 AM, Brian Norris
<computersforpeace at gmail.com> wrote:
> On Wed, Jan 07, 2015 at 10:37:20PM +0200, Andy Shevchenko wrote:
>> We need to compare ret variable for negative value. The current code
>> assigns the boolean to the ret and prints it wrongly in the warning
>> message.
>>
>> Reported-by: Andrey Karpov <karpov at viva64.com>
>> Cc: Giel van Schijndel <me at mortis.eu>
>> Cc: Dimitri Gorokhovik <dimitri.gorokhovik at free.fr>
>> Signed-off-by: Andy Shevchenko <andy.shevchenko at gmail.com>
>
> To be clear, this touches some commented out code (yuck). I think you
> noted this previously.

It had been proposed by Giel.

>
> For my reference, are you actually testing this driver?
>

Not a real testing. Only compilation on x86_32.

> Anyway, pushed to l2-mtd.git. Thanks.

Thanks!

>
> Brian



-- 
With Best Regards,
Andy Shevchenko



More information about the linux-mtd mailing list