[PATCH v2] mtd: nftl: reorganize operations in condition check

Brian Norris computersforpeace at gmail.com
Fri Jan 9 15:29:00 PST 2015


On Wed, Jan 07, 2015 at 10:37:20PM +0200, Andy Shevchenko wrote:
> We need to compare ret variable for negative value. The current code
> assigns the boolean to the ret and prints it wrongly in the warning
> message.
> 
> Reported-by: Andrey Karpov <karpov at viva64.com>
> Cc: Giel van Schijndel <me at mortis.eu>
> Cc: Dimitri Gorokhovik <dimitri.gorokhovik at free.fr>
> Signed-off-by: Andy Shevchenko <andy.shevchenko at gmail.com>

To be clear, this touches some commented out code (yuck). I think you
noted this previously.

For my reference, are you actually testing this driver?

Anyway, pushed to l2-mtd.git. Thanks.

Brian



More information about the linux-mtd mailing list