[PATCH] mtd: atmel-quadspi: fix compare_const_fl.cocci warnings

kbuild test robot lkp at intel.com
Mon Dec 7 07:25:21 PST 2015


drivers/mtd/spi-nor/atmel-quadspi.c:682:6-17: Move constant to right.

 Move constants to the right of binary operators.

Semantic patch information:
 Depends on personal taste in some cases.

Generated by: scripts/coccinelle/misc/compare_const_fl.cocci

CC: Cyrille Pitchen <cyrille.pitchen at atmel.com>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

 atmel-quadspi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/mtd/spi-nor/atmel-quadspi.c
+++ b/drivers/mtd/spi-nor/atmel-quadspi.c
@@ -679,7 +679,7 @@ static int atmel_qspi_init(struct atmel_
 	qspi_writel(aq, QSPI_CR, QSPI_CR_SWRST);
 
 	/* Set the QSPI controller in Serial Memory Mode */
-	mr = QSPI_MR_SSM | QSPI_MR_NBBITS(8);
+	mr = QSPI_MR_NBBITS(8) | QSPI_MR_SSM;
 	qspi_writel(aq, QSPI_MR, mr);
 
 	src_rate = clk_get_rate(aq->clk);



More information about the linux-mtd mailing list