[PATCH] mtd: atmel-quadspi: fix odd_ptr_err.cocci warnings
kbuild test robot
lkp at intel.com
Mon Dec 7 07:25:21 PST 2015
drivers/mtd/spi-nor/atmel-quadspi.c:758:5-11: inconsistent IS_ERR and PTR_ERR on line 760.
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call to
IS_ERR that is wrong.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Cyrille Pitchen <cyrille.pitchen at atmel.com>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---
Please take the patch only if it's a positive warning. Thanks!
atmel-quadspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/mtd/spi-nor/atmel-quadspi.c
+++ b/drivers/mtd/spi-nor/atmel-quadspi.c
@@ -757,7 +757,7 @@ static int atmel_qspi_probe(struct platf
aq->mem = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(aq->mem)) {
dev_err(&pdev->dev, "missing AHB memory\n");
- err = PTR_ERR(aq->regs);
+ err = PTR_ERR(aq->mem);
goto exit;
}
aq->phys_addr = (dma_addr_t)res->start;
More information about the linux-mtd
mailing list