[PATCH V4] mtd: gpmi: fix the bitflips for erased page

Brian Norris computersforpeace at gmail.com
Fri Mar 7 02:56:15 EST 2014


+ Pekon (he's doing something similar in OMAP NAND)

On Mon, Mar 03, 2014 at 08:47:07AM +0100, Elie De Brauwer wrote:
> On Fri, Feb 21, 2014 at 7:08 AM, Huang Shijie <b32955 at freescale.com> wrote:
> > On Mon, Jan 13, 2014 at 04:47:18PM +0800, Huang Shijie wrote:
> > Just a ping.
> >
> > could you merge this patch?
> 
> Also a ping from my side, I'm also a demanding party for a solution
> for this issue, and I'm also waiting for a solution to get applied
> upstream to integrate it into my board.

Hmm, I'm not terribly opposed to this patch, but you, Pekon, and I
(in my local driver) are all doing something very similar, and I believe
Pekon has gotten the logic wrong one or more times. I believe I actually
have a version of this type of patch locally that could probably be put
into the nand_base layer, with a flag so that drivers could request the
check themselves (something like chip->options |=
NAND_NEED_FF_ECC_CHECK; or pick your own name!).

What do you think? All interested parties please chime in. I can try to
push a patch out soon for you all to test soon, or else I can see about
taking your patches as-is for now, then try to unify them myself
afterward.

Brian



More information about the linux-mtd mailing list