[PATCH v2] ubifs: refactor ubifs_file_mmap()

Artem Bityutskiy dedekind1 at gmail.com
Mon Jul 28 09:25:13 PDT 2014


On Tue, 2014-07-22 at 14:28 +0800, Zhang Zhen wrote:
> generic_file_mmap() set vma->vm_ops = &generic_file_vm_ops,
> then ubifs_file_mmap set vma->vm_ops = &ubifs_file_vm_ops.
> So it is redundant.
> And there is no kind of file does not supply page reading function
> in ubifs. The readpage() check up for mmap file in generic_file_mmap()
> is not needed.
> 
> So remove the call of generic_file_mmap().
> 
> Change v1 -> v2:
> - deleted the mapping variable
> Signed-off-by: Zhang Zhen <zhenzhang.zhang at huawei.com>

Hi, I am not sure about this patch. 'generic_file_mmap()' covers !
CONFIG_MMU case too, for example.

Thanks!

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list