[PATCH v2] ubifs: refactor ubifs_file_mmap()
Zhang Zhen
zhenzhang.zhang at huawei.com
Mon Jul 21 23:28:43 PDT 2014
generic_file_mmap() set vma->vm_ops = &generic_file_vm_ops,
then ubifs_file_mmap set vma->vm_ops = &ubifs_file_vm_ops.
So it is redundant.
And there is no kind of file does not supply page reading function
in ubifs. The readpage() check up for mmap file in generic_file_mmap()
is not needed.
So remove the call of generic_file_mmap().
Change v1 -> v2:
- deleted the mapping variable
Signed-off-by: Zhang Zhen <zhenzhang.zhang at huawei.com>
---
fs/ubifs/file.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
index b5b593c..f7b6958 100644
--- a/fs/ubifs/file.c
+++ b/fs/ubifs/file.c
@@ -1540,11 +1540,7 @@ static const struct vm_operations_struct ubifs_file_vm_ops = {
static int ubifs_file_mmap(struct file *file, struct vm_area_struct *vma)
{
- int err;
-
- err = generic_file_mmap(file, vma);
- if (err)
- return err;
+ file_accessed(file);
vma->vm_ops = &ubifs_file_vm_ops;
return 0;
}
--
1.8.1.2
.
More information about the linux-mtd
mailing list