[PATCH 12/12] mtd: nand: provision full ID support

[Huang Shijie]

于 2013年03月05日 22:55, Artem Bityutskiy 写道:
> On Tue, 2013-03-05 at 22:36 +0800, Huang Shijie wrote:
>>>> We can add a new helper like compare_nand_with_devid() to remove the
>>>> mfr_id and dev_id, only left the id[8].
>>> Huang, did you miss the "union { ... }" part or you think using 'id[N]'
>>> directly is readable enough?
>> ｉ　ｔｈｉｎｋ　ｕｓｉｎｇ　ｔｈｅ　ｉｄ［］　ｉｓ　ｅｎｏｕｇｈ．
>> ｔｈｅ　ｕｎｉｏｎ　ｉｓ　ｒｅｄｕｎｄａｎｔ．
> I just find 'type->dev_id' more readable than 'type->id[1]'...
Just a suggestion, add more comments to the code will also make it readable.

But it's ok to me if you keep the union.

thanks
Huang Shijie