[PATCH 12/12] mtd: nand: provision full ID support

Artem Bityutskiy dedekind1 at gmail.com
Tue Mar 5 09:55:03 EST 2013


On Tue, 2013-03-05 at 22:36 +0800, Huang Shijie wrote:
> >> We can add a new helper like compare_nand_with_devid() to remove the
> >> mfr_id and dev_id, only left the id[8].
> >
> > Huang, did you miss the "union { ... }" part or you think using 'id[N]'
> > directly is readable enough?
> i think using the id[] is enough.
> the union is redundant.

I just find 'type->dev_id' more readable than 'type->id[1]'...

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list