[PATCH] mtd: add a new macro about the subpage write

[Brian Norris]

Hi Huang,

On Mon, Jul 2, 2012 at 10:32 PM, Huang Shijie <b32955 at freescale.com> wrote:
> The nand chip may does not support the subpage writes, while the nand
> controller may also does not support the subpage writes too.
>
> Now, the nand controller drivers use the NAND_NO_SUBPAGE_WRITE(0x00000200)
> to tell the MTD layer that they do not support the subpage writes. But
> this flag could be masked off in nand_get_flash_type():
>         ....................................................
>         /* Get chip options, preserve non chip based options */
>         chip->options &= ~NAND_CHIPOPTIONS_MSK;
>         ....................................................
...

It looks like you're finally getting around to solving your
NO_SUBPAGE_WRITE problem. I believe the discussion was left hanging a
few months ago. In that discussion, I'm beginning to agree with Scott
Wood [1]; I don't see a good reason not to just kill the
NAND_CHIPOPTIONS_MSK instead of adding more flags. As long as we
perform a few sanity tests, I think it'd be safe.

If somebody has a good reason not to remove NAND_CHIPOPTIONS_MSK,
though, I'd Ack this patch.

Regards,
Brian

[1] http://lists.infradead.org/pipermail/linux-mtd/2012-January/039144.html