GPMI-NAND: Wrong ECC size in driver

Scott Wood scottwood at freescale.com
Wed Jan 4 12:30:01 EST 2012


On 01/03/2012 11:58 PM, Huang Shijie wrote:
> Hi Marek:
>> Hi,
>>
>> the gpmi-nand.c driver apparently has misconfigured ecc.size field:
>>
>> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:
>> ---------->8 ----------
>> 1493         chip->ecc.mode          = NAND_ECC_HW;
>> 1494         chip->ecc.size          = 1;
>> 1495         chip->ecc.layout        =&gpmi_hw_ecclayout;
>> ---------- 8<  ----------
[snip]
> The gpmi driver does not support the subpage read/write.
> I will be happy if the driver works only by setting the
> NAND_NO_SUBPAGE_WRITE, without setting the ecc.size.

Can we just get rid of NAND_CHIPOPTIONS_MSK and trust that drivers won't
set options that aren't appropriate?  Possibly replace it with
documentation about which options are for chips, which are for drivers,
and which (such as NAND_NO_SUBPAGE_WRITE) can be set by either.

-Scott




More information about the linux-mtd mailing list