[PATCH v4] MTD: nand: add support for diskonchip G4 nand flash device

[Mike Dunn]

On 01/15/2012 03:06 AM, Robert Jarzmik wrote:
> I looked through. It looks good to me.


Thanks again Robert.


> I have one warning remaining (on top of Linus tree):
> drivers/mtd/nand/docg4.c: In function '__check_ignore_badblocks':
> drivers/mtd/nand/docg4.c:52: warning: return from incompatible pointer type


Ha! This is the result of a patch to moduleparam.h that just went in on Friday
(commit 72db395ffadb1d33233fd123c2bf87ba0198c6c1)

According to Rusty Russell, this will soon become a hard error.


>
> My feeling is that the driver is good to be sent upstream, with my:
> Reviewed-by: Robert Jarzmik <robert.jarzmik at free.fr>
>
> If anything comes up, it can be fixed later, and I think we should go forward.


I'd like to resubmit the patch to fix the warning.  Alternatively, I can follow
up with a separate patch once this one is pushed if the maintainers prefer.

Thanks,
Mike