[PATCH v4] MTD: nand: add support for diskonchip G4 nand flash device

[Robert Jarzmik]

Mike Dunn <mikedunn at newsguy.com> writes:

> On 01/10/2012 12:25 AM, Artem Bityutskiy wrote:
>>
>> Would be nice if DoC guys could also fix huge amount of GCC warnings -
>> there are DoC I/O macro definitions which produce a warning every time
>> they are used - very annoying noise. I guess those macros can be turned
>> into static inline functions? Would someone take the initiative?
>
>
> Yeah, this thought crossed my mind every time I recompiled while working on the
> aborted api change patches.  Gives DoC a bad name.  I'll get to it shortly.
>
> Ping Robert.  Care to take a look at the G4 driver?

I looked through. It looks good to me.
I have one warning remaining (on top of Linus tree):
drivers/mtd/nand/docg4.c: In function '__check_ignore_badblocks':
drivers/mtd/nand/docg4.c:52: warning: return from incompatible pointer type

My feeling is that the driver is good to be sent upstream, with my:
Reviewed-by: Robert Jarzmik <robert.jarzmik at free.fr>

If anything comes up, it can be fixed later, and I think we should go forward.

Cheers.

--
Robert