[PATCH v3 01/10] mtd: nand: add 'oob_required' argument to NAND {read,write}_page interfaces

[Brian Norris]

On Sun, Apr 29, 2012 at 6:25 AM, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> On Sun, 2012-04-29 at 14:36 +0300, Shmulik Ladkani wrote:
>> > Note: I couldn't compile-test all of these easily, as some had ARCH
>> > dependencies.
>> >
>> > Signed-off-by: Brian Norris <computersforpeace at gmail.com>
>>
>> Reviewed-by: Shmulik Ladkani <shmulik.ladkani at gmail.com>
>
> Brian, probably you take care of this, but just in case I would like to
> ask to put tags like this to your patches when re-sending. I am trying
> to be careful about this for several reasons: it shows that the patch
> was reviewed, it saves the reviewers name in the git history which and
> makes persons' contribution visible, so it is kind of a credit.

Sure, I'll do this as appropriate. Should I apply these tags when the
review is made w/o an explicit "Reviewed-by" (e.g., Scott Wood's
comments on patch 7)? There's also the issue of placing "reviewed-by"
before the reviewer actually sees my change.

So I'll be sure to place Shmulik's and Huang's tags. Not quite as sure
on Scott's review, but I will include it as "Reviewed-by" for now.

Brian