[PATCH 5/7] mtd: nand: read_page() returns max_bitflips

Shmulik Ladkani shmulik.ladkani at gmail.com
Wed Apr 25 05:20:43 EDT 2012


Hi Mike,

On Tue, 24 Apr 2012 12:18:23 -0700 Mike Dunn <mikedunn at newsguy.com> wrote:
> The ecc.read_page() method for nand drivers is changed to return the maximum
> number of bitflips that were corrected on any one region covering an ecc step,
> This patch doesn't change what the nand code returns to mtd.
> 
> This patch wasn't necessary in the earlier attempt at this effort because when
> max_bitflips referred to the entire page, the number of corrected bitflips could
> be obtained from the ecc_stats by the nand infrastructure code.
> 
> This basically follows Schmulik's suggested approach [1].  It was tested only on
> the docg4, but all drivers were compile-tested with the appropriate
> cross-compiler.
> 
> [1] http://lists.infradead.org/pipermail/linux-mtd/2012-March/040343.html
> 
> Signed-off-by: Mike Dunn <mikedunn at newsguy.com>

Reviewed nand_base.c, looks okay.

(though I wish we could avoid the max_bitflips calculation code
repetition)

Regards,
Shmulik



More information about the linux-mtd mailing list