[PATCH 1/7] ARM: add GPMI support for imx23/imx28
LW at KARO-electronics.de
Thu Mar 17 06:36:22 EDT 2011
Huang Shijie writes:
> > Huang Shijie writes:
> >> Hi Lothar:
> >>> Hi,
> >>> All in all I do not like this driver in any way. I already vomitted
> >>> over it, when I saw it in the Freescale BSP.
> >> :) I have already removed a lot of code.
> >>> There is no need for the multiple layers of abstraction that are
> >>> papered over the MTD layer.
> >> I think this is good. Make the code clear.
> > I'll comment when the remaining patch has got through.
> thanks a lot .
> >>> There is no need for spilling the driver over a dozen files.
> >> I can merge some files into one. thanks.
> > IMO all the source code could be kept in one file (except for the
> > include files of course) and the gpmi-nfc subdirectory removed.
> I really can merge some files, but IMHO, it's not a good solution to
> keep all in one file.
> The reasons are :
>  The GPMI support the NAND boot mode,but the imx23 and imx28 is a
> little different in
> the NAND boot procedure due the different firmwares in the chips. If I
> merge the rom-imx23.c
> rom-imx28.c to one file, the code will very mess. ugly enough!
You can use platform_ids to differentiate between the versions and
have separate functions for imx23 and imx28 where appropriate and
select between those depending on the platform_id.
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
More information about the linux-mtd