[PATCH] block2mtd: dubious assignment
Artem Bityutskiy
dedekind1 at gmail.com
Fri Oct 22 12:13:50 EDT 2010
On Fri, 2010-10-22 at 16:34 +0200, Jörn Engel wrote:
> On Fri, 22 October 2010 12:47:24 +0200, Nicolas Kaiser wrote:
> >
> > When block2mtd_erase fails, a duplicated assignment instantly
> > changes instr->state from MTD_ERASE_FAILED to MTD_ERASE_DONE.
> >
> > It looks to me like this might not be intended, or is it?
>
> Definitely not. Just proves how well block device errors are tested.
>
> > Signed-off-by: Nicolas Kaiser <nikai at nikai.net>
> Acked-By: Joern Engel <joern at logfs.org>
>
> Artem, can I leave this patch to you as well?
Yes, I'll put it to my l2 tree of course, thanks.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
More information about the linux-mtd
mailing list