[PATCH] block2mtd: dubious assignment

Jörn Engel joern at logfs.org
Fri Oct 22 10:34:16 EDT 2010


On Fri, 22 October 2010 12:47:24 +0200, Nicolas Kaiser wrote:
> 
> When block2mtd_erase fails, a duplicated assignment instantly
> changes instr->state from MTD_ERASE_FAILED to MTD_ERASE_DONE.
> 
> It looks to me like this might not be intended, or is it?

Definitely not.  Just proves how well block device errors are tested.

> Signed-off-by: Nicolas Kaiser <nikai at nikai.net>
Acked-By: Joern Engel <joern at logfs.org>

Artem, can I leave this patch to you as well?

Jörn

-- 
Eighty percent of success is showing up.
-- Woody Allen



More information about the linux-mtd mailing list