[PATCH RESEND][MTD]MLC device check in OneNAND driver
Rohit Hassan Sathyanarayan
rohit.hs at samsung.com
Thu Oct 7 00:32:02 EDT 2010
Hi Artem,
> -----Original Message-----
> From: Artem Bityutskiy [mailto:dedekind1 at gmail.com]
> Sent: Friday, September 24, 2010 5:22 PM
> To: Rohit Hassan Sathyanarayan
> Cc: linux-mtd at lists.infradead.org; gupta.raghav at samsung.com; v.dalal at samsung.com
> Subject: Re: [PATCH RESEND][MTD]MLC device check in OneNAND driver
>
> On Fri, 2010-09-24 at 17:10 +0530, Rohit Hassan Sathyanarayan wrote:
> > Signed-off-by: Rohit HS <rohit.hs at samsung.com>
> > Signed-off-by: Raghav Gupta <gupta.raghav at samsung.com>
>
> Almost perfect. However:
>
> 1. All mtd patches should have "mtd:" prefix.
> 2. Add some description about what you do and why into the commit
> message.
> 3. I think combining is not good, better do it old way - first patch
> introduces the flag, second uses it in OneNAND
>
We made changes as per your comments and have posted two patches,
Links of two patches,
http://lists.infradead.org/pipermail/linux-mtd/2010-September/032333.html
http://lists.infradead.org/pipermail/linux-mtd/2010-September/032334.html
> Sorry for being picky, but I really want to show you how to send patches
> properly once and later get good series from you.
>
> --
> Best Regards,
> Artem Bityutskiy (Артём Битюцкий)
More information about the linux-mtd
mailing list