[PATCH 3/3 -v3] MTD: Add nand_ecc test module

[vimal singh]

On Wed, Oct 21, 2009 at 2:21 PM, Artem Bityutskiy
<Artem.Bityutskiy at nokia.com> wrote:
> On Wed, 2009-10-21 at 17:34 +0900, Akinobu Mita wrote:
>> This module tests NAND ECC functions.
>>
>> The test is simple.
>>
>> 1. Create a 256 or 512 bytes block of data filled with random bytes (data)
>> 2. Duplicate the data block and inject single bit error (error_data)
>> 3. Try to correct error_data
>> 4. Compare data and error_data
>>
>> Signed-off-by: Akinobu Mita <akinobu.mita at gmail.com>
>> Cc: David Woodhouse <dwmw2 at infradead.org>
>> Cc: linux-mtd at lists.infradead.org
>> Cc: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
>> Cc: vimal singh <vimal.newwork at gmail.com>
>> ---
>>  drivers/mtd/tests/Makefile        |    1 +
>>  drivers/mtd/tests/nand_ecc-test.c |   87 +++++++++++++++++++++++++++++++++++++
>>  2 files changed, 88 insertions(+), 0 deletions(-)
>>  create mode 100644 drivers/mtd/tests/nand_ecc-test.c
>
> How about a consistent name for the test? All current tests have 'mtd_'
> prefix. How about make the file to be 'mtd_ecctest.c' ?

Or 'mtd_nandecctest.c'..? Since, anyways, this test is only for nand.

-- 
Regards,
Vimal Singh

>
> Also, since you anyway need to use these "#defines", I think there is
> not need to use this splitting. I apologize for leading you that way at
> the beginning.
>
> --
> Best Regards,
> Artem Bityutskiy (Артём Битюцкий)
>
>