[PATCH v2 2/3] NAND: Add new ECC mode - ECC_HW_OOB_FIRST

Paulraj, Sandeep s-paulraj at ti.com
Thu Jun 25 10:27:05 EDT 2009


I resubmitted this patch after fixing the compilation issue

> -----Original Message-----
> From: Artem Bityutskiy [mailto:dedekind at infradead.org]
> Sent: Monday, June 22, 2009 4:22 AM
> To: Paulraj, Sandeep
> Cc: davinci-linux-open-source at linux.davincidsp.com; linux-
> mtd at lists.infradead.org; dwmw2 at infradead.org; tglx at linutronix.de;
> akpm at linux-foundation.org; Narnakaje, Snehaprabha
> Subject: Re: [PATCH v2 2/3] NAND: Add new ECC mode - ECC_HW_OOB_FIRST
> 
> On Tue, 2009-06-16 at 16:23 -0400, s-paulraj at ti.com wrote:
> > From: Sandeep Paulraj <s-paulraj at ti.com>
> >
> > The patch applies to linux-mtd GIT tree
> >
> > This patch adds the new mode NAND_ECC_HW_OOB_FIRST in the nand code to
> > support 4-bit ECC on TI DaVinci devices with large page (up to 4K) NAND
> > chips. This ECC mode is similar to NAND_ECC_HW, with the exception of
> > read_page API that first reads the OOB area, reads the data in chunks,
> feeds
> > the ECC from OOB area to the ECC hw engine and perform any correction on
> the
> > data as per the ECC status reported by the engine.
> >
> > "ECC_HW_OOB_FIRST" name suggested by Thomas Gleixner
> >
> > Reviewed-by: David Brownell <dbrownell at users.sourceforge.net>
> > Signed-off-by: Sneha Narnakaje <nsnehaprabha at ti.com>
> > Signed-off-by: Sandeep Paulraj <s-paulraj at ti.com
> 
> I've applied your 3 patches and they do not compile:
> 
>   CC [M]  drivers/mtd/nand/nand_ecc.o
> drivers/mtd/nand/nand_base.c: In function ‘nand_scan_tail’:
> drivers/mtd/nand/nand_base.c:2724: error: ‘NAND_ECC_HW_OOB_FIRST’
> undeclared (first use in this function)
> drivers/mtd/nand/nand_base.c:2724: error: (Each undeclared identifier is
> reported only once
> drivers/mtd/nand/nand_base.c:2724: error: for each function it appears
> in.)
> make[3]: *** [drivers/mtd/nand/nand_base.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
>   CC [M]  drivers/mtd/devices/docprobe.o
> 
> --
> Best regards,
> Artem Bityutskiy (Битюцкий Артём)
> 



More information about the linux-mtd mailing list