[PATCH V5 1/2] mtd: nand: move layout structure into nand_ecc_ctrl

[Troy Kisky]

David Brownell wrote:
> On Thursday 16 July 2009, Troy Kisky wrote:
>>                 case 2048:
>> -                       nand_chip->ecc.layout = &atmel_oobinfo_large;
>> +                       memcpy(&nand_chip->ecc.layout, &atmel_oobinfo_large,
>> +                                       sizeof(nand_chip->ecc.layout));
>>                         ecc_writel(host->ecc, MR, ATMEL_ECC_PAGESIZE_2112);
>>                         break;
> 
> Surely using structure assignment
> 
> 			nand_chip->ecc.layout = atmel_oobinfo_large;
> 
> would be better, everywhere?
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 
Certainly would be easier to understand, but I thought it would generate
larger code, no?


No problem to change, I will next round, unless someone objects.

Thanks for the review.
Troy