[PATCH V5 1/2] mtd: nand: move layout structure into nand_ecc_ctrl

David Brownell david-b at pacbell.net
Fri Jul 17 15:46:49 EDT 2009


On Thursday 16 July 2009, Troy Kisky wrote:
>                 case 2048:
> -                       nand_chip->ecc.layout = &atmel_oobinfo_large;
> +                       memcpy(&nand_chip->ecc.layout, &atmel_oobinfo_large,
> +                                       sizeof(nand_chip->ecc.layout));
>                         ecc_writel(host->ecc, MR, ATMEL_ECC_PAGESIZE_2112);
>                         break;

Surely using structure assignment

			nand_chip->ecc.layout = atmel_oobinfo_large;

would be better, everywhere?




More information about the linux-mtd mailing list