[patch 2.6.30-rc1] NAND: don't walk past end of oobfree[]
David Brownell
david-b at pacbell.net
Tue Apr 7 19:54:55 EDT 2009
From: David Brownell <dbrownell at users.sourceforge.net>
Resolve issue noted by Sneha: when computing oobavail from
the list of free areas in the OOB, don't assume there will
always be an unused slot at the end. With ECC_HW_SYNDROME
and 4K page chips, it's fairly likely there *won't* be one.
Signed-off-by: David Brownell <dbrownell at users.sourceforge.net>
Cc: "Narnakaje, Snehaprabha" <nsnehaprabha at ti.com>"
---
Seems appropriate for a 2.6.30-rc merge.
drivers/mtd/nand/nand_base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2756,7 +2756,8 @@ int nand_scan_tail(struct mtd_info *mtd)
* the out of band area
*/
chip->ecc.layout->oobavail = 0;
- for (i = 0; chip->ecc.layout->oobfree[i].length; i++)
+ for (i = 0; chip->ecc.layout->oobfree[i].length
+ && i < ARRAY_SIZE(chip->ecc.layout->oobfree); i++)
chip->ecc.layout->oobavail +=
chip->ecc.layout->oobfree[i].length;
mtd->oobavail = chip->ecc.layout->oobavail;
More information about the linux-mtd
mailing list