[PATCH] Bug on atmel_nand HW ECC : OOB info not correctly written

Haavard Skinnemoen haavard.skinnemoen at atmel.com
Mon Oct 13 10:13:53 EDT 2008


David Woodhouse <dwmw2 at infradead.org> wrote:
> On Sun, 2008-10-12 at 08:42 +0200, Richard Genoud wrote:
> > The functions that write the OOB info (on hardware ECC only) use the
> > HW_SYNDROME method.
> > This is not correct : the start position is "pos = eccsize + chunk"
> > and should be eccsize.
> > So, the standard (nand_write_oob_std) function should be used.
> > This patch corrects this by using NAND_ECC_HW instead of
> > NAND_ECC_HW_SYNDROME.
> > 
> > This has only been tested on small pages nand flash.
> > (if anyone can test it on large pages that would be great).
> > 
> > kernel version : 2.6.27-rc2 (current git mtd-2.6)
> > 
> > Signed-off-by: Richard Genoud <richard.genoud at gmail.com>  
> 
> Håvard?

I have no clue, I'm afraid. What's the difference between NAND_ECC_HW
and NAND_ECC_HW_SYNDROME?

I do think I have a large page NAND flash available for testing though,
so I can do that. Will any potential problems be easy to spot?

In other words: What are the consequences of this bug?

Haavard



More information about the linux-mtd mailing list