[Patch][MTD][NAND] Rodan NAND controller

Jörn Engel joern at logfs.org
Mon May 5 14:23:00 EDT 2008


On Fri, 2 May 2008 15:04:39 -0700, Justin Treon wrote:
>
> +const static struct mtd_partition partition_info[] = {
> +	{
> +	 .name = "IMFT NAND",
> +	 .offset = 0,
> +	 .size = 256 * 1024 * 1024}
> +};

It took me a third look to find the closing brace.

> +	/* Initialize structures */
> +	memset((char *)rodan_mtd, 0, sizeof(struct mtd_info));
> +	memset((char *)this, 0, sizeof(struct nand_chip));

The casts don't seem necessary.

Otherwise looks fine to me.  So module the cosmetics, it is
Acked-By: Joern Engel <joern at logfs.org>

Jörn

-- 
Do not stop an army on its way home.
-- Sun Tzu



More information about the linux-mtd mailing list