[PATCH v2] mtd: Fix physmap_of to not exit upon unsuccessful partition scan

Stefan Roese sr at denx.de
Thu Feb 14 10:44:06 EST 2008

On Thursday 14 February 2008, Peter Korsgaard wrote:
> >>>>> "Stefan" == Stefan Roese <sr at denx.de> writes:
>  Stefan> The patch 9a310d21196f38f6ad0ad146057548653e495c09 ("[MTD]
>  Stefan> Factor out OF partition support from the NOR driver.")
>  Stefan> introduced an problem. Now the physmap_of driver returns with
>  Stefan> error upon the first unsuccessful partition scan
>  Stefan> (parse_mtd_partitions()). This is not wanted, since even when
>  Stefan> the RedBoot/cmdlinepart partition scan is unsuccessful, the
>  Stefan> other scan's (of_mtd_parse_partitions(),
>  Stefan> parse_obsolete_partitions()) should be done nevertheless.
> Doesn't it make more sense to fix the real problem (E.G. cmdlinepart.c
> flagging missing partition info as an error) - See the patch I posted
> earlier today.

Yes, this is probably even better. I just tested it successfully on my board.

Do you plan to post a "real patch" with Signed-off-by? You can add my Acked-by 
too then.

BTW: I would really like to see one of the solutions go into 2.6.25 since it's 
really a bug fix.


Best regards,

More information about the linux-mtd mailing list