JFFS2: Return values of jffs2_block_check_erase error paths

Joakim Tjernlund Joakim.Tjernlund at transmode.se
Thu Apr 10 17:03:12 EDT 2008


> -----Original Message-----
> From: linux-mtd-bounces at lists.infradead.org [mailto:linux-mtd-bounces at lists.infradead.org] On Behalf
> Of Anders Grafström
> Sent: den 10 april 2008 22:08
> To: linux-mtd at lists.infradead.org
> Subject: Re: JFFS2: Return values of jffs2_block_check_erase error paths
> 
> Anders Grafström wrote:
> > It looks like the error paths in jffs2_block_check_erase() have wrong return values.
> > A block that failed to be erased never gets marked as bad.
> >
> > Any comments on this patch?
> >
> > Anders
> >
> >
> > diff --git a/fs/jffs2/erase.c b/fs/jffs2/erase.c
> > index a1db918..23e9dd6 100644
> > --- a/fs/jffs2/erase.c


[SNIP]

> 
> 
> Nobody looked at this?
> This issue caused a corrupt file system.
> 
> /Anders

Looks good to me, but I think you should add your own signoff, write a
proper commit message and send it to Linus/Andrew as David appears busy.

Signed-off-by: Joakim Tjernlund <Joakim.Tjenrlund at transmode.se>




More information about the linux-mtd mailing list