[Patch 04/18] include/linux/logfs.h
Jörn Engel
joern at lazybastard.org
Mon Jun 4 05:12:45 EDT 2007
On Sun, 3 June 2007 23:42:25 +0200, Arnd Bergmann wrote:
> On Sunday 03 June 2007, Jörn Engel wrote:
> > +struct logfs_je_spillout {
> > + __be64 so_segment[0];
> > +}__packed;
>
> All the on-disk data structures you define in this file have naturally
> aligned members, so the __packed attribute is not needed.
Amen. It is purely paranoia and I don't even know who is out to get me.
> However, I think it causes gcc to generate larger and slower code
> on some architectures, because now it has to assume that the data
> structure itself has no more than byte alignment.
>
> I'd simply remove all instances of __packed therefore. In order
> to verify that you got it right in all cases, build with
> '-Wpadded -Wpacked'.
Fine with me. Will do.
Jörn
--
Ninety percent of everything is crap.
-- Sturgeon's Law
More information about the linux-mtd
mailing list