Re; MTD (2) Block Driver broken
joern at wohnheim.fh-wedel.de
Mon Mar 7 17:33:29 EST 2005
On Mon, 7 March 2005 22:10:17 +0000, Gareth Bult wrote:
> When I get time I'll test it. If it works, I may even use it. I'm not
> however desperate to have my name on it. Everyone screws up code - it's
> not a problem .. submitting changed code however without testing it is a
> little .. overconfident (?)
When I wrote it, I lacked the hardware to test it. Then I tested it
with mtdblock, and it worked. Then I tested it with jffs2 and that
didn't work. I suspected jffs2, spent a week (about 50-60 hours) on
that one, wrote 34 seperate patches for jffs2 and still couldn't find
Bug was actually in block2mtd, mtdblock just didn't trigger it. Darn!
Only after testing did I submit the code to cvs, so I was not
overconfident. Stupid is more to the point.
> I don't work on code for credit, I work on it because I enjoy it.
Well, the credit is free advertisement. On the next job interview, a
"just grep the kernel sources" comment explains my qualifications and
may keep me from unemployment here or raise my salary there.
Credit is never the reason to write code in the first place. My
block2mtd patches were written for fun and because I would like to
replace my hard driver with a USB key. But the free extra doesn't
hurt, at least until I win the lottery (and I never play).
Don't patch bad code, rewrite it.
-- Kernigham and Pike, according to Rusty
More information about the linux-mtd