[PATCH,RFC] remove slowport mode setting from ixp2000 map driver

Lennert Buytenhek buytenh at wantstofly.org
Mon Feb 21 10:41:21 EST 2005


(please CC on replies, not on the list)

Setting the slowport to 8-bit mode is something that ought to be
done in the IXP2000 generic code, not in the MTD map driver.  See
the description for ARM patch 2493/1 for an explanation.

	http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=2493/1

Now that 2493/1 has been accepted and will be upstream soon, this
doesn't need to be done in the map driver anymore.

Signed-off-by: Lennert Buytenhek <buytenh at wantstofly.org>


diff -urN linux-2.6.11-rc4.orig/drivers/mtd/maps/ixp2000.c linux-2.6.11-rc4/drivers/mtd/maps/ixp2000.c
--- linux-2.6.11-rc4.orig/drivers/mtd/maps/ixp2000.c	2004-12-24 22:35:39.000000000 +0100
+++ linux-2.6.11-rc4/drivers/mtd/maps/ixp2000.c	2005-02-21 16:12:03.313753034 +0100
@@ -216,11 +216,6 @@
 		goto Error;
 	}
 
-	/*
-	 * Setup read mode for FLASH
-	 */
-	*IXP2000_SLOWPORT_FRM = 1;
-
 #if defined(__ARMEB__)
 	/*
 	 * Enable erratum 44 workaround for NPUs with broken slowport





More information about the linux-mtd mailing list