No more DoC hotplug on Grub fail [tested & working]

[Mark Meade]

Henrik Nordström wrote:
> > This patch, while potentially useful during debugging, takes up precious
> > space that may be needed later (to add support for new flash devices,
> > etc).
>
> Exacly what kind of precious space does it take up? If you have another
> kind of flash device you better make another stage1 for that device,
> right?
>
> If the stage1 are size is a concern on DoC, then perhaps it should be
> considered to have a kind of "stage1.5" for DoC.

The boot block on the DoC Millennium is 512 bytes.  I believe this is also 
true for the DoC 2000.  Karim's patch used up the few remaining bytes, plus 
it was necessary to remove parts of the informational messages to make things 
fit.

To clarify, I was referring to adding support for detecting additional 
256-bytes per page devices.  The latest code looks at the device ID code to 
differentiate between 256-byte and 512-byte parts.

There really is no way to have a "stage1.5" in this case -- everything that 
is currently being done in doc_stage1 is required to copy Grub from the DoC 
to RAM.

> Also, for most practical purposes, having the "skip GRUB on this boot"
> check in stage2 would also be fine I think, except for the few who are
> playing around with custom stage1 loaders and those who are should
> probably have a setup where they can reflash their DoC without these
> concerns anyway..

Maybe, but then the stage2 code would have to know where to look for the 
BIOS's original handler, and also which one it was (18 or 19).  It would be 
*much* cleaner to leave this in stage1.

If this patch ends up in official GRUB, I'd recommend that we remove the 
section that displays the manufacturer and chip ID codes.  This should save 
enough space to make everything fit.

Mark