No more DoC hotplug on Grub fail [tested & working]

[Henrik Nordström]

On Wed, 4 Sep 2002, Mark Meade wrote:

> This patch, while potentially useful during debugging, takes up precious 
> space that may be needed later (to add support for new flash devices, etc).  

Exacly what kind of precious space does it take up? If you have another
kind of flash device you better make another stage1 for that device,
right?

If the stage1 are size is a concern on DoC, then perhaps it should be 
considered to have a kind of "stage1.5" for DoC. 

Also, for most practical purposes, having the "skip GRUB on this boot"  
check in stage2 would also be fine I think, except for the few who are
playing around with custom stage1 loaders and those who are should
probably have a setup where they can reflash their DoC without these
concerns anyway..

> Also, once Grub is booting correctly from the DoC, I would think this feature 
> would not be needed.

Except if a later upgrade of GRUB fails.. or you for some other reason 
need to bypass the GRUB in service purposes. Such as if the GRUB menu has 
got fucked up with no way to get to the GRUB prompt.

> For what it's worth, I'd recommend that this patch be made available in the 
> patches directory of the CVS tree, rather than making it part of the official 
> GRUB code.

Better than nothing ;-)

> I'm willing to revise my GRUB/DoC HOWTO to include instructions on the use of 
> this patch, for those who are concerned about this issue.

I would not install a GRUB without it. Have had to use it (and the M-Sys 
Alt+B sister) several times already due to various reasons..

Regards
Henrik