cmdline.c file name collision

[Hicks, Jamey]

> -----Original Message-----
> From: Scott Anderson [mailto:scott_anderson at mvista.com]
> Sent: Tuesday, November 12, 2002 12:47 PM
> To: linux-mtd at lists.infradead.org
> Subject: cmdline.c file name collision
> 
> 
> Hi all,
> 
> I recently noticed that when CONFIG_MODVERSIONS is turned on, both
> drivers/mtd/cmdline.c and lib/cmdline.c are trying to store their
> symbol versions in include/linux/modules/cmdline.ver in a 2.4 kernel
> tree.  Only one of them "wins" leaving the versioned symbols of the
> other undefined.  It seems to me that drivers/mtd/cmdline.c should
> probably be renamed to avoid the conflict.  Thoughts?
> 

hmm.  My first thought was to rename drivers/mtd/cmdline.c to drivers/mtd/mtdcmdline.c or drivers/mtd/cmdlinepart.c.

Actually, that was my second thought.  My first thought was to wonder why CONFIG_MODVERSIONS flattens the kernel source file namespace.  I just turned on CONFIG_MODVERSIONS to build an ipaq kernel, and I find I also have a name conflict on arch/arm/mach-sa1100/pm.c and kernel/pm.c.

Jamey