MTD concat layer

[Robert Kaiser]

On Fri, 15 Feb 2002, David Woodhouse wrote:

> 
> > +#if defined(CONFIG_MTD_CONCAT) || defined(CONFIG_MTD_CONCAT_MODULE) 
> 
> Don't ever do that. Modules should be, well, modular - don't make other 
> stuff depend on whether you happened to build a particular module today or 
> not.
> 

OK, I'll change it.

> It doesn't look like you have the concat_erase code right. An erase which 
> covers more than one subdev will only get partially done.

OK, will look into this. I stole that part from Aleksander Sanochkin's
patch. I did test it, BTW (with erase/eraseall), and it worked.
Apparently, these tools erase the device block by block. Is it
legal/supported at all to make erase calls covering multiple blocks or
partial blocks ?

> 
> I think the best way to do this would be to merge it with the existing
> partition code.


Hmm, I agreed with you about this before I actually attempted coding it
this way, but the code turned out to be a mess. IMHO, it is _much_ cleaner
as a seperate layer. What would be the advantage of merging it into the
partition code ?

Disadvantages are:

- more overhead for parties requiring only partitioning or only
  concatenating.
- significant effort, specifically since the current partitioning
  code is scheduled for replacement by Jörn's code, so I'd have to
  do it twice.

Cheers

Rob

----------------------------------------------------------------
Robert Kaiser                          email: rkaiser at sysgo.de
SYSGO RTS GmbH
Am Pfaffenstein 14
D-55270 Klein-Winternheim / Germany    fax:   (49) 6136 9948-10