cfi_amdext_sync, cfi_intelext_sync

[David Woodhouse]

On Fri, 6 Oct 2000, Alice Hennessy wrote:

> Hi,
> 
> Found a bug in cfi_cmdset_0001.c and  cfi_cmdset_0002.c in functions
> cfi_intelext_sync and cfi_amdext_sync respectively.  The call to
> remove_wait_queue is missing after the "add_wait_queue;spin_unlock_bh;
> schedule"   sequence in the default case.

Doh! Well spotted. 

> A nice touch is that we are in spin_lock_bh so the system hangs as well.

Thinks.... it's too early in the morning for me to decide whether it's
safe to drop the lock _before_ calling wake_up(). Probably. 

> If you agree, should I check in the fix?

Yes please.

-- 
dwmw2




To unsubscribe, send "unsubscribe mtd" to majordomo at infradead.org