mtd: nand: atmel: Fix get_sectorsize() function

Linux-MTD Mailing List linux-mtd at lists.infradead.org
Thu Mar 29 10:59:02 PDT 2018


Gitweb:     http://git.infradead.org/?p=mtd-2.6.git;a=commit;h=2b1b1b4ac716fd929a2d221bd4ade62263bed915
Commit:     2b1b1b4ac716fd929a2d221bd4ade62263bed915
Parent:     3eb2ce825ea1ad89d20f7a3b5780df850e4be274
Author:     Boris Brezillon <boris.brezillon at bootlin.com>
AuthorDate: Tue Mar 27 19:01:58 2018 +0200
Committer:  Boris Brezillon <boris.brezillon at bootlin.com>
CommitDate: Thu Mar 29 19:29:06 2018 +0200

    mtd: nand: atmel: Fix get_sectorsize() function
    
    get_sectorsize() was not using the appropriate macro to extract the
    ECC sector size from the config cache, which led to buggy ECC when
    using 1024 byte sectors.
    
    Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
    Cc: <stable at vger.kernel.org>
    Reported-by: Olivier Schonken <olivier.schonken at gmail.com>
    Signed-off-by: Boris Brezillon <boris.brezillon at bootlin.com>
    Reviewed-by: Richard Weinberger <richard at nod.at>
    Acked-by: Nicolas Ferre <nicolas.ferre at microchip.com>
    Tested-by: Olivier Schonken <olivier.schonken at gmail.com>
---
 drivers/mtd/nand/atmel/pmecc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c
index fcbe4fd6e684..ca0a70389ba9 100644
--- a/drivers/mtd/nand/atmel/pmecc.c
+++ b/drivers/mtd/nand/atmel/pmecc.c
@@ -426,7 +426,7 @@ static int get_strength(struct atmel_pmecc_user *user)
 
 static int get_sectorsize(struct atmel_pmecc_user *user)
 {
-	return user->cache.cfg & PMECC_LOOKUP_TABLE_SIZE_1024 ? 1024 : 512;
+	return user->cache.cfg & PMECC_CFG_SECTOR1024 ? 1024 : 512;
 }
 
 static void atmel_pmecc_gen_syndrome(struct atmel_pmecc_user *user, int sector)



More information about the linux-mtd-cvs mailing list